On Thu, 2018-03-29 at 23:03 -0700, Quytelda Kahja wrote: > If we just want to have the address field full of zeros during the > driver probe, is there a reason we should zero it explicitly here? > When the 'struct net_device' is first allocated using > alloc_etherdev(), the dev_addr field is explicitly set to zeros (in > the subfunction dev_addr_init() in net/core/dev_addr_lists.c), so it > should be zeroed already at this point in the code. You didn't describe the removal in your commit message so it looked unintentional. You should describe _why_ it's OK to remove it in that commit message. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel