Re: [PATCH 6/6] staging: ks7010: factor out some functions from hostif_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergio,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20180323]
[cannot apply to v4.16-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sergio-Paracuellos/staging-ks7010-use-GENMASK-instead-of-custom-defines-in-SME_WEP_VAL_MASK/20180324-123656
config: i386-randconfig-x013-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/ks7010/ks_hostif.c: In function 'hostif_aplist_init':
>> drivers/staging/ks7010/ks_hostif.c:2363:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     size_t size = LOCAL_APLIST_MAX * sizeof(struct local_ap_t);
     ^~~~~~

vim +2363 drivers/staging/ks7010/ks_hostif.c

  2359	
  2360	static inline void hostif_aplist_init(struct ks_wlan_private *priv)
  2361	{
  2362		priv->aplist.size = 0;
> 2363		size_t size = LOCAL_APLIST_MAX * sizeof(struct local_ap_t);
  2364		memset(&priv->aplist.ap[0], 0, size);
  2365	}
  2366	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux