On Fri, Mar 23, 2018 at 03:03:29PM +0000, Ruxandra Ioana Ciocoi Radulescu wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Friday, March 23, 2018 5:01 PM > > To: Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@xxxxxxx> > > Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 2/9] staging: fsl-dpaa2/eth: Move print message > > > > On Fri, Mar 23, 2018 at 08:44:06AM -0500, Ioana Radulescu wrote: > > > Let the driver remove() function print an informative message > > > after it finishes removing the network interface, not at an > > > arbitrary point during cleanup. > > > > > > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@xxxxxxx> > > > --- > > > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > > index beb5959..9fb88f2 100644 > > > --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > > +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > > @@ -2550,7 +2550,6 @@ static int dpaa2_eth_remove(struct > > fsl_mc_device *ls_dev) > > > priv = netdev_priv(net_dev); > > > > > > unregister_netdev(net_dev); > > > - dev_info(net_dev->dev.parent, "Removed interface %s\n", > > net_dev->name); > > > > > > if (priv->do_link_poll) > > > kthread_stop(priv->poll_thread); > > > @@ -2571,6 +2570,8 @@ static int dpaa2_eth_remove(struct > > fsl_mc_device *ls_dev) > > > dev_set_drvdata(dev, NULL); > > > free_netdev(net_dev); > > > > > > + dev_info(net_dev->dev.parent, "Removed interface %s\n", > > net_dev->name); > > > > Why is this even needed? I'll take it but spamming kernel logs for no > > reason is not a good idea :) > > Fair point, should I make it dev_dbg instead? Yeah, that's a lot nicer, thanks. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
