Re: [PATCH 11/12] staging: ks7010: replace uint8_t in favour of u8 in michael_append

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 22, 2018 at 08:19:22PM +0100, Sergio Paracuellos wrote:
> This commit replaces param which is uint8_t in michael_append
> function in favour of preferred one u8.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> ---
>  drivers/staging/ks7010/michael_mic.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c
> index 69c1f39..04831eaa 100644
> --- a/drivers/staging/ks7010/michael_mic.c
> +++ b/drivers/staging/ks7010/michael_mic.c
> @@ -60,7 +60,7 @@ static inline void michael_block(u32 *l, u32 *r)
>  	*l += *r;
>  }
>  
> -static void michael_append(struct michael_mic_t *mic, uint8_t *src, int bytes)
> +static void michael_append(struct michael_mic_t *mic, u8 *src, int bytes)
>  {
>  	int addlen;
>  
> @@ -138,8 +138,8 @@ void michael_mic_function(struct michael_mic_t *mic, u8 *key,
>  	 * +--+--+--------+--+----+--+--+--+--+--+--+--+--+
>  	 */
>  	michael_init(mic, key);
> -	michael_append(mic, (uint8_t *)data, 12);	/* |DA|SA| */
> +	michael_append(mic, data, 12);	/* |DA|SA| */
>  	michael_append(mic, pad_data, 4);	/* |Priority|0|0|0| */
> -	michael_append(mic, (uint8_t *)(data + 12), len - 12);	/* |Data| */
> +	michael_append(mic, (data + 12), len - 12);	/* |Data| */

You may as well remove the parentheses as well.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux