On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: > This commit replaces MichaelBlockFunction macro with similar inline function > renaming it to michael_block. > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > --- > drivers/staging/ks7010/michael_mic.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c > index 6829cb5..07913d0 100644 > --- a/drivers/staging/ks7010/michael_mic.c > +++ b/drivers/staging/ks7010/michael_mic.c > @@ -48,17 +48,17 @@ static void michael_init(struct michael_mic_t *mic, uint8_t *key) > michael_clear(mic); > } > > -#define MichaelBlockFunction(L, R) \ > -do { \ > - R ^= rol32(L, 17); \ > + *l ^= rol32(*l, 17); It feels like this should be: *r ^= rol32(*l, 17); right? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel