On Mon, Feb 07, 2011 at 12:57:50PM +0000, Ian Abbott wrote: > It looks like Greg replied to the patch: And I replied to him, but it looks like my reply got lost. Shame on me for not checking. Here it is again for posterity, showing that it is not a modprobe issue. On Fri, Jan 28, 2011 at 10:15:21AM -0500, W. Trevor King wrote: > On Thu, Jan 27, 2011 at 06:03:39PM -0800, Greg KH wrote: > > Odds are you didn't run 'depmod' after installing the kernel then, > > right? > > I installed the modules with > # make modules_install > which, I believe, runs depmod automatically. > > To test, I just commented out my patch additions, and ran > # make && make modules_install > ... > DEPMOD 2.6.36-gentoo-r5 > # modprobe ni_pcimio > FATAL: Error inserting ni_pcimio (/lib/modules/2.6.36-gentoo-r5/kernel/drivers/staging/comedi/drivers/ni_pcimio.ko): Unknown symbol in module, or unknown parameter (see dmesg) > # modprobe -r ni_pcimio > # depmod -a > # modprobe ni_pcimio > FATAL: Error inserting ni_pcimio (/lib/modules/2.6.36-gentoo-r5/kernel/drivers/staging/comedi/drivers/ni_pcimio.ko): Unknown symbol in module, or unknown parameter (see dmesg) > # modprobe -r ni_pcimio > > Then I re-enabled my patch, and it works: > # make && make modules_install > ... > # modprobe ni_pcimio > # lsmod > Module Size Used by > ni_pcimio 43224 0 > ni_tiocmd 4132 1 ni_pcimio > comedi_fc 1108 1 ni_pcimio > mite 5974 2 ni_pcimio,ni_tiocmd > 8255 2692 1 ni_pcimio > comedi 21130 5 ni_pcimio,ni_tiocmd,comedi_fc,mite,8255 > ni_tio 10381 2 ni_pcimio,ni_tiocmd > > > > With the metadata macros, ni_pcimio loads successfully. > > > > I don't see how that would work a all. I'm not saying that this is an > > incorrect patch, but that it shouldn't solve a module dependancy > > problem. > > I have no idea why it would work either. It seems quite unrelated. I > got the idea by reading > http://www.linuxforums.org/forum/kernel/56497-unkown-symbol-module-error-while-insmodding-but-should-fine.html > > While trying to diagnose the problem, I noticed that in > drivers/staging/comedi/Kconfig, COMEDI_NI_PCIMIO doesn't depend on > COMEDI_FC, which it should. Perhaps that has something to do with it? > Despite the omission, depmod seems to pick up the dependency: > # modinfo /lib/modules/2.6.36-gentoo-r5/kernel/drivers/staging/comedi/drivers/ni_pcimio.ko | grep depends > depends: comedi,mite,ni_tio,8255,ni_tiocmd,comedi_fc > so I didn't think that was too much of a problem. On Mon, Feb 07, 2011 at 01:17:10PM +0000, Ian Abbott wrote: > You can drop this patch if you want, as I'm planning to submit a > replacement for this patch that adds license information to all the NI > comedi drivers that don't have it already. Great! Consider my patch request officially dropped ;). Trevor -- This email may be signed or encrypted with GPG (http://www.gnupg.org). The GPG signature (if present) will be attached as 'signature.asc'. For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy My public key is at http://www.physics.drexel.edu/~wking/pubkey.txt
Attachment:
pgplzGXmAg0SV.pgp
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
