[PATCH 4/7] staging: mt7621-dma: Remove assignment in if

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if

Signed-off-by: Christian Lütke-Stetzkamp <christian@xxxxxxxx>
---
 drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c
index 9548ce4afb77..60d557fb6553 100644
--- a/drivers/staging/mt7621-dma/ralink-gdma.c
+++ b/drivers/staging/mt7621-dma/ralink-gdma.c
@@ -678,6 +678,7 @@ static enum dma_status gdma_dma_tx_status(struct dma_chan *c,
 
 	spin_lock_irqsave(&chan->vchan.lock, flags);
 	desc = chan->desc;
+	vdesc = vchan_find_desc(&chan->vchan, cookie);
 	if (desc && (cookie == desc->vdesc.tx.cookie)) {
 		/*
 		 * We never update edesc->residue in the cyclic case, so we
@@ -689,7 +690,7 @@ static enum dma_status gdma_dma_tx_status(struct dma_chan *c,
 				((chan->next_sg - 1) * desc->sg[0].len);
 		else
 			state->residue = desc->residue;
-	} else if ((vdesc = vchan_find_desc(&chan->vchan, cookie)))
+	} else if (vdesc)
 		state->residue = to_gdma_dma_desc(vdesc)->residue;
 	spin_unlock_irqrestore(&chan->vchan.lock, flags);
 
-- 
2.13.6

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux