Re: [PATCH 5/6] staging: ks7010: Fix line over 80 characters.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-03-19 at 22:58 -0700, Quytelda Kahja wrote:
> There is no reason for comment describing the BSSID check for loop
> to be spaced so far to the right.  Move it above the for loop.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -844,7 +844,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>  	ap_info = (struct ap_info_t *)(priv->rxp);
>  
>  	if (priv->scan_ind_count) {
> -		for (i = 0; i < priv->aplist.size; i++) {	/* bssid check */
> +		/* bssid check */
> +		for (i = 0; i < priv->aplist.size; i++) {
>  			if (memcmp(ap_info->bssid,
>  				   priv->aplist.ap[i].bssid, ETH_ALEN) != 0)

this could also use ether_addr_equal

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux