On Sun, Feb 06, 2011 at 03:28:46PM -0800, Andres Salomon wrote: > bool mono:1; > + bool asleep:1; ^^ Not needed. > - return sprintf(buf, "%d\n", dcon_sleep_val); > + struct dcon_priv *dcon = dev_get_drvdata(dev); > + return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0); ^^^^^^^ Also not needed. These are fussy things. Feel free to fix them in a later patch series. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel