Re: [PATCH 1/3] staging: ks7010: remove useless DPRINTK traces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 14, 2018 at 9:13 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Tue, Mar 13, 2018 at 05:55:20PM +0100, Sergio Paracuellos wrote:
>> @@ -786,14 +723,6 @@ void hostif_connect_indication(struct ks_wlan_private *priv)
>>
>>       switch (connect_code) {
>>       case RESULT_CONNECT:    /* connect */
>> -             DPRINTK(3, "connect :: scan_ind_count=%d\n",
>> -                     priv->scan_ind_count);
>> -             if (!(priv->connect_status & FORCE_DISCONNECT))
>> -                     netif_carrier_on(netdev);
>> -             tmp = FORCE_DISCONNECT & priv->connect_status;
>> -             priv->connect_status = tmp + CONNECT_STATUS;
>> -             break;
>> -     case RESULT_DISCONNECT: /* disconnect */
>>               DPRINTK(3, "disconnect :: scan_ind_count=%d\n",
>>                       priv->scan_ind_count);
>>               netif_carrier_off(netdev);
>
> I was on board until this chunk.  You got a bit carried away.

I do not understand how that could have happened. Sorry for this. From
now I will be more careful in reviewing my own patches.

I'll review these and send v2.

Thanks,

>
> regards,
> dan carpenter

Best regards,
   Sergio Paracuellos
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux