> -----Original Message----- > From: Andrew Lunn [mailto:andrew@xxxxxxx] > Sent: Monday, March 12, 2018 4:37 PM > To: Razvan Stefanescu <razvan.stefanescu@xxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Alexander Graf > <agraf@xxxxxxx>; arnd@xxxxxxxx; Alexandru Marginean > <alexandru.marginean@xxxxxxx>; Ruxandra Ioana Ciocoi Radulescu > <ruxandra.radulescu@xxxxxxx>; Ioana Ciornei <ioana.ciornei@xxxxxxx>; > Laurentiu Tudor <laurentiu.tudor@xxxxxxx>; stuyoder@xxxxxxxxx > Subject: Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 > Ethernet Switch driver > > > +static int port_netdevice_event(struct notifier_block *unused, > > + unsigned long event, void *ptr) > > +{ > > + struct net_device *netdev = netdev_notifier_info_to_dev(ptr); > > + struct netdev_notifier_changeupper_info *info = ptr; > > + struct net_device *upper_dev; > > + int err = 0; > > + > > + if (netdev->netdev_ops != ðsw_port_ops) > > + return NOTIFY_DONE; > > + > > + /* Handle just upper dev link/unlink for the moment */ > > + if (event == NETDEV_CHANGEUPPER) { > > + upper_dev = info->upper_dev; > > + if (netif_is_bridge_master(upper_dev)) { > > + if (info->linking) > > + err = port_bridge_join(netdev); > > + else > > + err = port_bridge_leave(netdev); > > + } > > + } > > + > > + return notifier_from_errno(err); > > +} > > I could be missing something here, but don't you need to pass to > port_bridge_join() which bridge the port is joining. There can be > multiple bridges, so you need to ensure the port joins the correct > bridge. > Thank you for noticing this. I'll add proper checks in next version. Razvan > Andrew _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
