On Thu, 8 Mar 2018 12:58:19 +0530 Himanshu Jha <himanshujha199640@xxxxxxxxx> wrote: > On Wed, Mar 07, 2018 at 08:50:30PM +0000, Jonathan Cameron wrote: > > On Mon, 5 Mar 2018 13:19:29 +0530 > > Himanshu Jha <himanshujha199640@xxxxxxxxx> wrote: > > > > > Clarify the conversion and formation of resultant data in the > > > adis16201_read_raw() with sufficient comments. > > > > > > Signed-off-by: Himanshu Jha <himanshujha199640@xxxxxxxxx> > > This is fine but it needs to be in the original comment changing patch > > rather than removing the comments first then a few patches later putting > > back a different version. > > > > So good change but in the wrong place in the series. Learning to reorder > > a series and merge down multiple patches into one is very useful when > > working with git. > > I will send v2 with all the updates! > > What about sign_extend32 & reverse christmas ordering patch ? Will you > pick that up or shall I send them again ? Please repost anything not yet applied in V2 of the series. Makes it much easier for me to avoid missing patches! Thanks, Jonathan > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
