Re: [PATCH 2/4] staging:iio:ad2s1210: Remove unused #define directive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Mar 2018 20:46:05 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> wrote:

> This patch removes some #define directives not used in the code.
> 
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx>
Applied.

One comment inline.
> ---
>  drivers/staging/iio/resolver/ad2s1210.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 0cdcd71e285b..79cb56670fc2 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -35,8 +35,6 @@
>  #define AD2S1210_SET_RES1		0x02
>  #define AD2S1210_SET_RES0		0x01
>  
> -#define AD2S1210_SET_ENRESOLUTION	(AD2S1210_SET_ENRES1 |	\
> -					 AD2S1210_SET_ENRES0)
>  #define AD2S1210_SET_RESOLUTION		(AD2S1210_SET_RES1 | AD2S1210_SET_RES0)
>  
>  #define AD2S1210_REG_POSITION		0x80
> @@ -53,10 +51,6 @@
>  #define AD2S1210_REG_SOFT_RESET		0xF0
>  #define AD2S1210_REG_FAULT		0xFF
>  
> -/* pin SAMPLE, A0, A1, RES0, RES1, is controlled by driver */
> -#define AD2S1210_SAA		3
> -#define AD2S1210_PN		(AD2S1210_SAA + AD2S1210_RES)
> -
>  #define AD2S1210_MIN_CLKIN	6144000
>  #define AD2S1210_MAX_CLKIN	10240000
>  #define AD2S1210_MIN_EXCIT	2000
> @@ -64,10 +58,6 @@
>  #define AD2S1210_MIN_FCW	0x4
>  #define AD2S1210_MAX_FCW	0x50
>  
> -/* default input clock on serial interface */
I'm not sure what this has to do with the serial interface.
It's the clk input from an external clock source.

> -#define AD2S1210_DEF_CLKIN	8192000
> -/* clock period in nano second */
> -#define AD2S1210_DEF_TCK	(1000000000 / AD2S1210_DEF_CLKIN)
>  #define AD2S1210_DEF_EXCIT	10000
>  
>  enum ad2s1210_mode {

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux