With my new rename_rev.pl script I can review this patch by typing: | ~/progs/kernel/rename_rev.pl '\(struct \w+ \*\)NULL' NULL '\(void \*\)NULL' NULL Then a cursory look for white space problems. The old way was to: 1) Review version 1. 2) Star all the messages in the thread. 3) Save the starred messages as an mbox. 4) Save version 3 as a new mbox. 5) Diff the two mail boxes. I can do this new way in one line, without leaving mutt. :) regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel