Tobin, I understand your point, and I've read submitting-patches.rst. I made that wording choice because I was looking at some older commits that were worded like that. I'm fairly new to the kernel workflow, so I was just trying to emulate something established, and it sounded less stilted than my imperative attempts. However, I will word my change logs in the imperative as best I can in the future. Thank you, Quytelda Kahja On Thu, Mar 1, 2018 at 12:54 PM, Tobin C. Harding <me@xxxxxxxx> wrote: > On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote: >> On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote: >> > On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote: >> > > The code that generates a WLAN capability mask is repeated in five >> > > functions. This change refactors that code into a new function, which is >> > > called now in each of those functions. >> > >> > Perhaps in future something like: >> > >> > Code to generate the WLAN capability mask is duplicated five times >> > >> > Add helper function to generate WLAN capability mask, refactor code to >> > use newly defined function. >> > >> >> I honestly don't see the difference between that and what Quytelda >> wrote? I understood the original changelog just fine. >> >> regards, >> dan carpenter > > I had a feeling that the sentiment of the suggestion I was trying to get > at didn't come across, thanks for pointing it out. I was intending to > suggest not using sentences like this > > > This change refactors that code into a new function, which is > > called now in each of those functions. > > And instead use, as suggested in submitting-patches.rst, imperative mood > > Refactor code into new function ... > > FTR I find the English bits of kernel dev (and programming in general) > the most difficult even though English is my first language. I would > like to write it better. > > > Hope this helps, > Tobin. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
