[staging:staging-testing 217/217] drivers/staging/nvec/nvec_power.c:361:10: warning: 'return' with a value, in function returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head:   501b9cb070bc35073f4195b58e74098a9d31375c
commit: 501b9cb070bc35073f4195b58e74098a9d31375c [217/217] staging: nvec: add error checking to nvec_event
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 501b9cb070bc35073f4195b58e74098a9d31375c
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/staging/nvec/nvec_power.c: In function 'nvec_power_poll':
>> drivers/staging/nvec/nvec_power.c:361:10: warning: 'return' with a value, in function returning void
      return err;
             ^~~
   drivers/staging/nvec/nvec_power.c:348:13: note: declared here
    static void nvec_power_poll(struct work_struct *work)
                ^~~~~~~~~~~~~~~

vim +/return +361 drivers/staging/nvec/nvec_power.c

   347	
   348	static void nvec_power_poll(struct work_struct *work)
   349	{
   350		int err;
   351		char buf[] = { NVEC_SYS, GET_SYSTEM_STATUS };
   352		struct nvec_power *power = container_of(work, struct nvec_power,
   353							poller.work);
   354	
   355		if (counter >= ARRAY_SIZE(bat_iter))
   356			counter = 0;
   357	
   358		/* AC status via sys req */
   359		err = nvec_write_async(power->nvec, buf, 2);
   360		if (err != 0)
 > 361			return err;
   362	
   363		msleep(100);
   364	
   365		/*
   366		 * Select a battery request function via round robin doing it all at
   367		 * once seems to overload the power supply.
   368		 */
   369		buf[0] = NVEC_BAT;
   370		buf[1] = bat_iter[counter++];
   371		nvec_write_async(power->nvec, buf, 2);
   372	
   373		schedule_delayed_work(to_delayed_work(work), msecs_to_jiffies(5000));
   374	};
   375	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux