The first 5 patches are good, but the last 3 are not OK. Normally "tmp" is used as an iterator pointer or something along those lines. For example, here is a good use of "tmp". tmp = left; left = right; right = tmp; In this example, you want to store a pointer temporarily, so what else are you going to call it besides "tmp"? The name "tmp" doesn't mean "I want a short name and I'm too lazy to think of one". regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel