There's no need to check the return value of debug_file for it is just a debugfs and we will go on the following process if we failed to create debug_file. So just remove it. Signed-off-by: Yisheng Xie <xieyisheng1@xxxxxxxxxx> --- drivers/staging/android/ion/ion.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 74d9a4e..0606d50 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -522,7 +522,6 @@ static int debug_shrink_get(void *data, u64 *val) void ion_device_add_heap(struct ion_heap *heap) { - struct dentry *debug_file; struct ion_device *dev = internal_dev; int ret; @@ -556,12 +555,8 @@ void ion_device_add_heap(struct ion_heap *heap) char debug_name[64]; snprintf(debug_name, 64, "%s_shrink", heap->name); - debug_file = debugfs_create_file(debug_name, - 0644, dev->debug_root, heap, - &debug_shrink_fops); - if (!debug_file) - pr_err("Failed to create ion heap shrinker debugfs at %s\n", - debug_name); + debugfs_create_file(debug_name, 0644, dev->debug_root, + heap, &debug_shrink_fops); } dev->heap_cnt++; -- 1.7.12.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel