On Wed, Feb 21, 2018 at 01:45:58PM +0300, Dan Carpenter wrote:
> On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> > Changed a variable name from camel to snake case to fix a coding style
> > issue.
> >
> > Signed-off-by: Quytelda Kahja <quytelda@xxxxxxxxx>
> > ---
> > drivers/staging/gdm724x/hci_packet.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
> > index 22ce8b9477b6..f8837c7103ac 100644
> > --- a/drivers/staging/gdm724x/hci_packet.h
> > +++ b/drivers/staging/gdm724x/hci_packet.h
> > @@ -50,7 +50,7 @@ struct tlv {
> > struct sdu_header {
> > __dev16 cmd_evt;
> > __dev16 len;
> > - __dev32 dftEpsId;
> > + __dev32 dft_eps_ID;
>
> I bet this is a part of the user space ABI or there is a specific reason
> for the name to match the spec or something so it can't be changed...
This structure is not even used anywhere :(
Quytelda, can you just remove all unused structure definitions from this
driver? That would be a much better patch here instead of changing a
structure field that no one uses.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
