On Wed, Feb 02, 2011 at 02:05:59PM -0800, Joe Perches wrote:
> Convert logical tests with styles like:
> "if (test == true)" to "if (test)"
> "if (test == false)" to "if (!test)"
> etc.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> .../staging/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c | 6 +-
> .../staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.c | 2 +-
> drivers/staging/ath6kl/os/linux/ar6000_drv.c | 28 ++--
> drivers/staging/ath6kl/os/linux/ar6000_pm.c | 2 +-
> drivers/staging/ath6kl/os/linux/ar6k_pal.c | 4 +-
> drivers/staging/ath6kl/os/linux/cfg80211.c | 34 ++--
> drivers/staging/ath6kl/os/linux/ioctl.c | 244 ++++++++++----------
> drivers/staging/ath6kl/os/linux/wireless_ext.c | 56 +++---
> drivers/staging/ath6kl/wmi/wmi.c | 16 +-
> 9 files changed, 196 insertions(+), 196 deletions(-)
>
> @@ -3547,7 +3547,7 @@ wmi_set_fixrates_cmd(struct wmi_t *wmip, u32 fixRatesMask)
> /* Make sure all rates in the mask are valid in the current PHY mode */
> for(rateIndex = 0; rateIndex < MAX_NUMBER_OF_SUPPORT_RATES; rateIndex++) {
> if ((1 << rateIndex) & (u32)fixRatesMask) {
> - if (wmi_is_bitrate_index_valid(wmip, rateIndex) != true) {
> + if (wmi_is_bitrate_index_valid(!wmip, rateIndex)) {
> A_DPRINTF(DBG_WMI, (DBGFMT "Set Fix Rates command failed: Given rate is illegal in current PHY mode\n", DBGARG));
> return A_EINVAL;
> }
Joe,
The above needs to be changed from
if (wmi_is_bitrate_index_valid(!wmip, rateIndex)) {
to
if (!wmi_is_bitrate_index_valid(wmip, rateIndex)) {
I am ok if you change it in the subsequent set of patches but pls
do keep track of that.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
