Re: [PATCH] Staging: ks7010: Fix Unnecessary parentheses in ks_hostif.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 17, 2018 at 12:58:46PM +0530, Yash Omer wrote:
> This patch fixes up unnecessary parenthesis issue found by checkpatch.pl
> 
> Signed-off-by: Yash Omer <yashomer0007@xxxxxxxxx>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 975dbbb3abd0..7bd567e233d7 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -850,7 +850,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>  		DPRINTK(4, " scan_ind_count=%d :: aplist.size=%d\n",
>  			priv->scan_ind_count, priv->aplist.size);
>  		get_ap_information(priv, (struct ap_info_t *)(priv->rxp),
> -				   &(priv->aplist.ap[priv->scan_ind_count - 1]));
> +				   &(priv->aplist.ap priv->scan_ind_count - 1));

Yash, you seem like a nice person but this isn't even a vaguely
reasonable change.  This isn't valid C.  You really need to learn C
before you can make a meaningful contribution to the kernel.  :(

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux