Hi Rodrigo, I think this is a nice finding. One comment inline: On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > argument 'struct device *' should also have an identifier name... > > + int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val); > + int (*write_reg_8)(struct device *dev, u16 reg_address, u8 value); Any particular reason for using val vs value? I get that one is a pointer and another a plain type, but I think the name should be the same. thanks, Daniel. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
