Re: [PATCH] Staging: comedi: fix camelcase issue in range.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 15, 2018 at 01:36:43AM +0530, Yash Omer wrote:
> This is a patch to the range.c file that fixes up a camelcase warning found by 	the checkpatch.pl tool.
> 
> Signed-off-by: Yash Omer <yashomer0007@xxxxxxxxx>
> ---
>  drivers/staging/comedi/range.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
> index 087bbde7bf12..ec128a6a70bb 100644
> --- a/drivers/staging/comedi/range.c
> +++ b/drivers/staging/comedi/range.c
> @@ -24,7 +24,7 @@ EXPORT_SYMBOL_GPL(range_unipolar5);
>  const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
>  EXPORT_SYMBOL_GPL(range_unipolar2_5);
>  const struct comedi_lrange RANGE_0_20m_A = { 1, {RANGE_m_A(0, 20)} };
> -EXPORT_SYMBOL_GPL(range_0_20mA);
> +EXPORT_SYMBOL_GPL(range_0_20m_A);

That change really does not make that much sense, does it?  Checkpatch
is a hint, you don't want to change wyat "mA" means, right?

And did you test-build this change?  It should not work as-is :(

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux