On Mon, Feb 12, 2018 at 08:11:57PM +0530, Himanshu Jha wrote: > On Mon, Feb 12, 2018 at 04:18:26PM +0300, Dan Carpenter wrote: > > I think -M is prefered for these types of diffs? Not sure. > > I wrote about that in the cover letter if you missed. :) > Yeah. I seldom read cover letters. > > > + ret = adis_init(st, indio_dev, spi, &adis16201_data); > > > + if (ret) > > > + return ret; > > > + > > > + ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL); > > > + if (ret) > > > + return ret; > > > > We should clean up the IRQ which we enabled in adis_init() instead of > > returning directly. > > I'm not sure about how to do that. > I believe in you that you can figure it out. :) regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
