Hi all, When I tried to review the code of ion, I find that there are many place can be cleanup, so I post this patchset. I mark it as v2, because I have post them in different patchset before[1][2] [3][4]. And now, I combine them in one patchset to make it easy to review, Meanwhile, I add some acks and rebase them to v4.15-rc1. Thanks. [1] https://lkml.org/lkml/2018/1/31/711 [2] https://lkml.org/lkml/2018/2/1/240 [3] https://lkml.org/lkml/2018/2/4/320 [4] https://lkml.org/lkml/2018/2/6/949 Yisheng Xie (9): staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings staging: android: ion: Remove unused include files for ion_page_pool.c staging: android: ion: Nuke ion_page_pool_init staging: android: ion: Avoid NULL point in error path staging: android: ion: Remove lable debugfs_done staging: android: ion: Remove dead code in ion_page_pool_free staging: android: ion: Return void instead of int staging: android: ion: Cleanup ion_page_pool_alloc_pages staging: android: ion: Combine cache and uncache pools drivers/staging/android/ion/ion.c | 20 ++----- drivers/staging/android/ion/ion.h | 22 +------- drivers/staging/android/ion/ion_page_pool.c | 33 ++---------- drivers/staging/android/ion/ion_system_heap.c | 76 +++++---------------------- 4 files changed, 24 insertions(+), 127 deletions(-) -- 1.7.12.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel