Hi Laura, On 2018/2/7 6:51, Laura Abbott wrote: > On 01/31/2018 01:50 AM, Yisheng Xie wrote: >> ion_page_pool.c now is used to apply pool APIs for system heap, which do >> not need do any initial at device_initcall. >> >> Meanwhile, this patch also remove some useless include files. >> > > Acked-by: Laura Abbott <labbott@xxxxxxxxxx> Thanks, and I split this into two small patchs as Greg's suggestion in a resent patch. Yisheng > >> Signed-off-by: Yisheng Xie <xieyisheng1@xxxxxxxxxx> >> --- >> drivers/staging/android/ion/ion_page_pool.c | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c >> index 817849d..3c1eba5 100644 >> --- a/drivers/staging/android/ion/ion_page_pool.c >> +++ b/drivers/staging/android/ion/ion_page_pool.c >> @@ -14,12 +14,7 @@ >> * >> */ >> -#include <linux/debugfs.h> >> -#include <linux/dma-mapping.h> >> -#include <linux/err.h> >> -#include <linux/fs.h> >> #include <linux/list.h> >> -#include <linux/init.h> >> #include <linux/slab.h> >> #include <linux/swap.h> >> @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool) >> { >> kfree(pool); >> } >> - >> -static int __init ion_page_pool_init(void) >> -{ >> - return 0; >> -} >> -device_initcall(ion_page_pool_init); >> > > > . > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel