On Wed, Jan 31, 2018 at 09:39:51PM -0800, Quytelda Kahja wrote: > Removed parenthesis causing a coding style warning. > > Signed-off-by: Quytelda Kahja <quytelda@xxxxxxxxxxx> > --- > drivers/staging/fwserial/dma_fifo.c | 2 +- > drivers/staging/fwserial/fwserial.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c > index 8b23a553fd4a..ead71f93f3c9 100644 > --- a/drivers/staging/fwserial/dma_fifo.c > +++ b/drivers/staging/fwserial/dma_fifo.c > @@ -259,7 +259,7 @@ int dma_fifo_out_complete(struct dma_fifo *fifo, struct dma_pending *complete) > if (list_empty(&fifo->pending) && fifo->open == 0) > return -EINVAL; > > - if (FAIL(fifo, list_empty(&fifo->pending) != (fifo->open == 0), > + if (FAIL(fifo, list_empty(&fifo->pending) != fifo->open == 0, No no no... You've changed what the code does here... I'm so surprised the compiler doesn't complain. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel