On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
>> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> >> In preparation for adding a warning ("kconfig: Warn if help text is
>> >> blank"): https://lkml.org/lkml/2018/1/30/516
>> >>
>> >
>> > Please don't start the boddy of the email in the middle of a sentence.
>> >
>> > It looks like this:
>> >
>> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
>> >
>> > Notice how the subject is up above the From, Date, and Message-id email
>> > headers? It's totally disconnected from the body of the email.
>> >
>> > regards,
>> > dan carpenter
>>
>> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
>>
>
> I do feel that patch descriptions should say what the patch does as well
> as why. Right now the subject says what but I normally read either the
> body or the subject but not both.
>
> regards,
> dan carpenter
>
I fleshed out the individual commit messages and rolled a new
patchset, which adds the warning at the end:
https://lkml.org/lkml/2018/1/31/137
I wonder why that one doesn't display with proper threading on LKML.
It does show the entire thread once you click on one of the later
messages.
Cheers,
Ulf
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
