Re: [staging-next 1/4] staging: easycap: don't cast NULL pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 01, 2011 at 07:39:02AM +0200, Winkler, Tomas wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:greg@xxxxxxxxx]
> > Sent: Tuesday, February 01, 2011 12:01 AM
> > To: Winkler, Tomas
> > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx
> > Subject: Re: [staging-next 1/4] staging: easycap: don't cast NULL pointer
> > 
> > On Tue, Jan 25, 2011 at 05:33:27PM +0200, Tomas Winkler wrote:
> > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> > 
> > Something in this patch series causes the following build breakage to
> > happen:
> > drivers/staging/easycap/easycap_sound_oss.c:711:29: error: expected â=â,
> > â,â, â;â, âasmâ or â__attribute__â before âioctlâ
> > drivers/staging/easycap/easycap_sound_oss.c:1009:20: error:
> > âeasyoss_unlocked_ioctlâ undeclared here (not in a function)
> > make[3]: *** [drivers/staging/easycap/easycap_sound_oss.o] Error 1
> 
> Hmm, looks like broken comment or something like that...here compiles everything fine.
> Sorry for troubles I will check that again.

Make sure you have the OSS config option selected, I think that might be
the issue.

> > Care to fix it up and resend _all_ of the easycap patches you have sent
> > to me but that I haven't applied?  I've purged them all from my to-apply
> > queue as I don't want to mess with picking some and not others as that
> > gets messy really quickly.
> 
> Sure.
> > 
> > Also, are you working with the original author of this driver to do this
> > work?  If not, please do so.
> 
> Mike has expressed in a private conversation and also on this list
> that he has no more time to working on this project so I've dropped
> him from the CC list. 

Please at least cc: him, it's only the nice thing to do.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux