On Sun, Jan 21, 2018 at 04:05:26PM +0000, Sidong Yang wrote:
> Fix checkpatch.pl warning message about logging code. Previous code
> contains hard coded function name. Fix this code by using __func__
> macro.
>
> Signed-off-by: Sidong Yang <realwakka@xxxxxxxxx>
> ---
> drivers/staging/most/dim2/dim2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index 21e3fb48bdb4..f9bc7dea75b8 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -151,7 +151,7 @@ void dimcb_io_write(u32 __iomem *ptr32, u32 value)
> */
> void dimcb_on_error(u8 error_id, const char *error_message)
> {
> - pr_err("dimcb_on_error: error_id - %d, error_message - %s\n", error_id,
> + pr_err("%s: error_id - %d, error_message - %s\n", __func__, error_id,
> error_message);
> }
>
This is ok, but this function should really be removed and just use
dev_err() instead everywhere this is called. And there's no need for
yet-another-wrapper-function dim_on_error() that does nothing but call
this function as well. Too many levels of indirection for no reason...
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
