> -----Original Message----- > From: Cathy Avery [mailto:cavery@xxxxxxxxxx] > Sent: Tuesday, January 16, 2018 6:36 AM > To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>; KY Srinivasan > <kys@xxxxxxxxxxxxx> > Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; James E.J. Bottomley > <jejb@xxxxxxxxxxxxxxxxxx>; Martin K. Petersen > <martin.petersen@xxxxxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe() > > On 01/16/2018 05:40 AM, Dan Carpenter wrote: > > We should set the error code if fc_remote_port_add() fails. > > > > Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.") > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > > index 3b3d1d050cac..40fc7a590e81 100644 > > --- a/drivers/scsi/storvsc_drv.c > > +++ b/drivers/scsi/storvsc_drv.c > > @@ -1834,8 +1834,10 @@ static int storvsc_probe(struct hv_device > *device, > > fc_host_node_name(host) = stor_device->node_name; > > fc_host_port_name(host) = stor_device->port_name; > > stor_device->rport = fc_remote_port_add(host, 0, &ids); > > - if (!stor_device->rport) > > + if (!stor_device->rport) { > > + ret = -ENOMEM; > > goto err_out4; > > + } > > } > > #endif > > return 0; > > Reviewed-by: Cathy Avery <cavery@xxxxxxxxxx> Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
