On Thu, Jan 11, 2018 at 06:16:55PM +0100, Fabian Huegel wrote: > Checkpatch wants complex macros to be enclosed in parentheses, so we > put parentheses around these four macros. > > Signed-off-by: Fabian Huegel <fabian_huegel@xxxxxx> > Signed-off-by: Christoph Volkert <linux@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/staging/lustre/lustre/include/obd_class.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > index 67c535c..5c8cf30 100644 > --- a/drivers/staging/lustre/lustre/include/obd_class.h > +++ b/drivers/staging/lustre/lustre/include/obd_class.h > @@ -294,10 +294,10 @@ struct obdo; > > void obdo_to_ioobj(const struct obdo *oa, struct obd_ioobj *ioobj); > > -#define OBT(dev) (dev)->obd_type > -#define OBP(dev, op) (dev)->obd_type->typ_dt_ops->op > -#define MDP(dev, op) (dev)->obd_type->typ_md_ops->op > -#define CTXTP(ctxt, op) (ctxt)->loc_logops->lop_##op > +#define OBT(dev) ((dev)->obd_type) > +#define OBP(dev, op) ((dev)->obd_type->typ_dt_ops->op) > +#define MDP(dev, op) ((dev)->obd_type->typ_md_ops->op) > +#define CTXTP(ctxt, op) ((ctxt)->loc_logops->lop_##op) That really doesn't make any sense, as this can only be a variable in here, not any "complex expression". Sometimes checkpatch.pl isn't very smart. Also, these macros are horridly named, odds are they are not even needed... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
