Re: [PATCH 06/10] uio_hv_generic: create send and receive buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 04, 2018 at 02:13:30PM -0800, Stephen Hemminger wrote:
> Map in receive and send buffers for networking in UIO device.
> These buffers are special and need to be setup by kernel
> API's.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> ---
>  drivers/uio/uio_hv_generic.c | 114 +++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 109 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
> index 24f8689fdb14..0d945eb6efbb 100644
> --- a/drivers/uio/uio_hv_generic.c
> +++ b/drivers/uio/uio_hv_generic.c
> @@ -35,7 +35,7 @@
>  
>  #include "../hv/hyperv_vmbus.h"
>  
> -#define DRIVER_VERSION	"0.02.0"
> +#define DRIVER_VERSION	"0.02.1"

The driver version should be deleted, it means nothing as the code is in
the kernel tree.

>  #define DRIVER_AUTHOR	"Stephen Hemminger <sthemmin at microsoft.com>"
>  #define DRIVER_DESC	"Generic UIO driver for VMBus devices"
>  
> @@ -46,19 +46,38 @@ static unsigned int ring_size = 128;
>  module_param(ring_size, uint, 0444);
>  MODULE_PARM_DESC(ring_size, "Ring buffer size (# of pages)");
>  
> -/*
> - * List of resources to be mapped to user space
> - * can be extended up to MAX_UIO_MAPS(5) items
> - */
> +#define RECV_BUFFER_MAX ((16 * 1024 * 1024) / PAGE_SIZE)
> +
> +static unsigned int recv_buffer_size = RECV_BUFFER_MAX;
> +module_param(recv_buffer_size, uint, 0444);
> +MODULE_PARM_DESC(recv_buffer_size, "Receive buffer size (# of pages)");
> +
> +#define SEND_BUFFER_MAX ((15 * 1024 * 1024) / PAGE_SIZE)
> +
> +static unsigned int send_buffer_size = SEND_BUFFER_MAX;
> +module_param(send_buffer_size, uint, 0444);
> +MODULE_PARM_DESC(send_buffer_size, "Send buffer size (# of pages)");

Same comments about the module options :(

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux