On Tue, Jan 09, 2018 at 05:11:52PM +0100, Hans de Goede wrote: > Hi, > > On 09-01-18 17:02, Luis de Bethencourt wrote: > > On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: > > > On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote: > > > > Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxx> > > > > --- > > > > > > I can't take patches without any changelog text, sorry :( > > > > > > > Hi Greg, > > > > I have done some research around previous patches to this driver and > > I am not entirely sure what you mean. > > > > Sorry, but I need to ask before sending a v2. > > > > Do you mind I'm missing a small summary in the commit message? Fix is > > so small I thought just the commit subject would be enough. > > > > It is something different let me know and I will correct it. > > I'm not entirely sure, but I believe Greg may have a script for this, > given the amount of mail he receives and commits without a changelog > in general not being a good idea. No script for this, yet :) > What I usually do with trivial patches like this, is simply take the > part after the last : in the subject, append a "." and voila you've > a changelog txt. So in this case that would simply be: > > Fix trailing semicolon. Ick, no, come on, you can do it correctly... greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel