On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote: > Hi Joe, > > On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote: > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > index a1c81c12718c..4338b8a1309f 100644 > > --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > @@ -158,10 +158,10 @@ static ssize_t dynamic_pool_show(struct device *dev, > > return ret; > > }; > > > > -static DEVICE_ATTR(active_bo, 0444, active_bo_show, NULL); > > -static DEVICE_ATTR(free_bo, 0444, free_bo_show, NULL); > > -static DEVICE_ATTR(reserved_pool, 0444, reserved_pool_show, NULL); > > -static DEVICE_ATTR(dynamic_pool, 0444, dynamic_pool_show, NULL); > > +static DEVICE_ATTR_RO(active_bo); > > +static DEVICE_ATTR_RO(free_bo); > > +static DEVICE_ATTR_RO(reserved_pool); > > +static DEVICE_ATTR_RO(dynamic_pool); > > > > static struct attribute *sysfs_attrs_ctrl[] = { > > &dev_attr_active_bo.attr, > > I have the exact same changes queued up in my tree. As there seem to be no > dependencies to other patches in your set, how about dropping this chunk? I've now dropped it, thanks. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel