Re: [PATCH] Staging: vt6656: fix unnecessary parantheses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 22, 2017 at 07:53:52PM +0530, Sumit Pundir wrote:
> This patch fixes a coding style issue as noted by
> checkpatch.pl related to unnecessary parentheses.
> 
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Unnecessary parentheses around 'priv->basic_rates'.
> 
> Signed-off-by: Sumit Pundir <pundirsumit11@xxxxxxxxx>
> ---
>  drivers/staging/vt6656/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index 501f482..811602e 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
>  	int ii;
> 
>  	for (ii = RATE_54M; ii >= RATE_6M; ii--) {
> -		if ((priv->basic_rates) & ((u16)BIT(ii)))
> +		if (priv->basic_rates & ((u16)BIT(ii)))

You still have one too many () around the BIT stuff...

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux