Re: [PATCH 2/3] staging: greybus: audio_codec.c: Fix multiple checkpatch errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 19, 2017 at 09:55:05PM +0200, Kamal Heib wrote:
> This patch fixes the following errors found by checkpatch:
> 1- Prefer kernel type 'u32' over 'uint32_t'.
> 2- Space required around that ':'.
> 3- Alignment should match open parenthesis.
> 4- Don't use multiple blank lines.

When you have to list the different things a patch does, that's a huge
sign that it needs to be broken up.

Yeah, this is a small file, but please break this up into a patch
series.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux