Re: [PATCH 2/3] staging: dgnc: dgnc_cls.c: remove unnecessary parentheses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 16, 2017 at 10:16:00PM +0200, Kamal Heib wrote:
> Cleanup the "Unnecessary parentheses around <expr>" checkpatch.pl error.
> 
> Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index e264fe11cba4..aed6e9cb24a6 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -706,7 +706,7 @@ static void cls_param(struct tty_struct *tty)
>  		 * unit is NOT open
>  		 */
>  		if (!(ch->ch_tun.un_flags & UN_ISOPEN) &&
> -		    (un->un_type == DGNC_PRINT))
> +		    un->un_type == DGNC_PRINT)

Same complaint here.  Checkpatch is a "hint", don't do things that make
it harder to understand the code.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux