On Sun, 2017-12-17 at 15:07 +0530, Shreeya Patel wrote: > Replace true and false keywords with "x" and "!x" > respectively to follow the kernel coding style. [] > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c [] > @@ -191,8 +191,8 @@ static u32 sdio_read32(struct intf_hdl *pintfhdl, u32 addr) > rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); > if ( > ((deviceId == WLAN_IOREG_DEVICE_ID) && (offset < 0x100)) || > - (false == bMacPwrCtrlOn) || > - (true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) > + (!bMacPwrCtrlOn) || When you do these sorts of conversions can you please remove the unnecessary parentheses too? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
