Re: [PATCH 03/10] staging: pi433: space prohibted before that close parentesis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 08, 2017 at 05:22:49PM +0100, Oliver Graute wrote:
> ERROR: space prohibited before that close parenthesis
>  ')' +                                        kthread_should_stop() );
> 
> Signed-off-by: Oliver Graute <oliver.graute@xxxxxxxxx>
> ---
>  drivers/staging/pi433/pi433_if.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ok, now you are breaking things up into too small of pieces :)

This has the same subject as the previous patch, if you fix the spelling
mistakes, which is another huge hint that they should be merged.

Again, do one "logical" thing per patch.  Fixing up all of the same type
of coding style error in the same patch, for the same driver, is fine
for one patch.

So this should be a smaller series of patches.

Please fix up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux