On 12/06/2017 07:01 AM, Greg KH wrote: > On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote: >> This patch fix several brace on next line, braces not necessary, space >> around =/<, and space before/after open/close parenthesis coding style >> errors find by checkpatch in pi433_if.c. >> >> In addition, the interrupt routine DIO0_irq_handler logic is updated: >> - use 'switch' statement instead of 'if/else if' combination for the >> sake of readability, and >> - use dev_dbg_ratelimited instead of dev_dbg to avoid message flooding. > When you have to add "in addition" to a changelog comment, that's a huge > flag that the patch needs to be broken up into a patch series. Please > do that here, only doing one "logical" thing at a time. As it is, it's > hard to review this way. > > thanks, > > greg k-h OK, I see, no problem. Thanks Tomas _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
