On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote: > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 +++++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > + # let's wait for 3 minutes > > Was this codepath runtime tested? > > Last time this came up, the conclusion was that Windows terminates the > "KVP connection" after 60 seconds. After that, the VM must be rebooted > because the kernel does not deal with the long-running script. It is > also not clear what the kernel is supposed to do: either silently report > success and hope the scripts reports success one day, or report error > independent from what the script actually returns. New KVP requests > would need to be queued either way. > Now that you mentioned, I guess my tests never touched this part. But I guess we're going to fix this downstream-only setting a rule on systemd to start hypervkvpd only after NetworkManager started. Please drop the reviews on this. Regards, _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
