Re: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also when it does:
	memcpy(ft1000dev->tx_buf, *pUcFile, byte_length);

That should probably be:
	memcpy(ft1000dev->tx_buf, *pUcFile, word_length * 4);

Otherwise we're probably copying garbage from beyond the end of *pUcFile
to the ->tx_buf.  ft1000dev->tx_buf is hopefully initialized to zero at
this point?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux