Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 02.12.2017 um 18:09 schrieb Greg KH:

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Dec 02, 2017 at 06:00:28PM +0200, Marcus Wolf wrote:
Hi Greg,

for me the action was "clean up the defines in rf69.c". So for me it was
fine, that two defines were moved and several other deleted at the same.

Is it ok for you, or should I split the patch belated?

Please split it up, and make a patch series.  Don't dribble patches out
over many hours as that just ensures that I will apply them in the wrong
order :(

Take the time, make a patch series, test that they pass the scripts that
we have, and then send them all out at once.

thanks,

greg k-h


Hi Greg,

thanks for the info on patch series. I thought series are to be used if the patches are logicaly linked together. Didn't know, that patch series even is ok, if the patches deal with different topics.

I am working with kernel quite rarely. So it's quite hard to do everything 100% correct. I already took a lot of time today, to try to make everything perfect. That's why I was working on these five patches for all the day (aka 7h). And there was no need to implement a single line - everything was already implemented and tested on HW in July.
But 7h weren't enough or wasted: Again not a single patch was ok :-(

I can understand, your time is limited, too. But with constantly having no success and constant redo from start, the motivation is fading. Don't know, whether there could be a better way, how to build up a volunteer. This way - I am sorry - is frustrating.

Since I have another peace of software, that needs to be implemented (not just moved into patches) for a customer (paying for it) until tomorrow, I will leave / have to leave the hobby topic pi433 for now.

Please skip all my patches and I'll give them a third try - maybe arround Christmas...

Thanks,

Marcus
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux