On Thu, 30 Nov 2017 21:13:34 +0530
Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Applied to the togreg branch of iio.git. This is probably just
a theoretical problem as obviously the blackfin trigger only runs
on blackfin boards and I assume they only return 0.
Anyhow, nothing wrong with tidying it up as might possible get
cut and paste to somewhere it does matter in future!
Jonathan
> ---
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> index d80dcf8..f389f5c 100644
> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> @@ -187,9 +187,9 @@ static int iio_bfin_tmr_trigger_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> st->irq = platform_get_irq(pdev, 0);
> - if (!st->irq) {
> + if (st->irq < 0) {
> dev_err(&pdev->dev, "No IRQs specified");
> - return -ENODEV;
> + return st->irq;
> }
>
> ret = iio_bfin_tmr_get_number(st->irq);
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
