Re: [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Nguyen Phan Quang Minh <minhnpq16@xxxxxxxxx>
Subject: Re: [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 1 Dec 2017 17:26:10 +0300
Cc: devel@xxxxxxxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20171201142343.a3mqavi2xhbqjany@mwanda>
References: <20171130214014.GA4405@minhnpqrs-antergos> <20171201142343.a3mqavi2xhbqjany@mwanda>
User-agent: NeoMutt/20170609 (1.8.3)

Also it's not a style issue, it's a bug.  We double call the failing
function on error.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

References:
- [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues
  - From: Nguyen Phan Quang Minh
- Re: [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues
Next by Date: Re: [PATCH 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.
Previous by thread: Re: [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues
Next by thread: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux