Re: [PATCH 3/3] staging: brcm80211: align common driver code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Tue, 25 Jan 2011 15:58:54 +0100, Greg KH <gregkh@xxxxxxx> wrote:

On Tue, Jan 25, 2011 at 02:32:05PM +0100, Arend van Spriel wrote:
Remove differences in util sources for the two supported drivers

But this patch also makes it possible for both to be build at the same
time, right?  Which should be called out here.


PATCH 2 makes it possible to build the drivers at the same time, but
I have to change that as it uses symbolic links iso include.

Why not make that its own patch?

and remove default print statements.

Ah, you used "and".  This means you should not be doing this all in one
patch.


Ok. This means you want me to split and resubmit this patch?

Remember, "one patch per thing" is the rule here.

thanks,

greg k-h


Gr. AvS

--
Using Opera's revolutionary email client: http://www.opera.com/mail/

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux