Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 27, 2017 at 05:51:56PM +0000, Hartley Sweeten wrote:
> On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote:
> > On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
> >> +		const struct comedi_lrange *lrange;
> >
> > NAK.  The following lines of source code allocate memory pointed to by 'lrange' and modify it, so 'const' is not appropriate here.
> 
> Ian,
> 
> Wonder if it's worth putting a comment about this in the code. This has come up a
> couple times.

It's a nice test to see who actually builds the code before they send a
patch in :)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux