Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote:
> This patch set fixes bugs and integrates the driver to the kernel's device
> model by revising its architecture. Part of this change is rearranging the
> directory layout, renaming of files and folders and thereby creating a
> clean driver structure.

Ok I've now applied all of these to my testing branch.  I think you need
to make some follow-up patches:
	- fix the build to actually compile the individual drivers :)
	- make DEVICE_ATTR structures static
	- use ATTRIBUTE_GROUPS where you can
	- use DEVICE_ATTR_RW() and _RO and _WO instead of a "raw"
	  DEVICE_ATTR() call.  There should not be any need to be having
	  any "special" file permissions for all of these attributes.
	- make sure you do not have any "empty" release functions.  I
	  saw one you removed, verify you don't have any others.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux