Re: [PATCH 09/50] staging: most: remove proprietary kobjects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 21, 2017 at 03:04:43PM +0100, Christian Gromm wrote:
> This patch removes the proprietary kobjects used by the driver modules and
> replaces them with device structs. The patch is needed to have the driver
> being integrated into the kernel's device model.
> 
> Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx>
> ---
>  drivers/staging/most/cdev/cdev.c   |   6 +-
>  drivers/staging/most/core.c        | 803 +++++++++++--------------------------
>  drivers/staging/most/core.h        |  13 +-
>  drivers/staging/most/dim2/dim2.c   |  19 +-
>  drivers/staging/most/dim2/sysfs.c  |  92 +----
>  drivers/staging/most/dim2/sysfs.h  |   6 +-
>  drivers/staging/most/i2c/i2c.c     |   7 +-
>  drivers/staging/most/net/net.c     |   3 +-
>  drivers/staging/most/sound/sound.c |   3 +-
>  drivers/staging/most/usb/usb.c     | 243 +++--------
>  drivers/staging/most/video/video.c |   3 +-
>  11 files changed, 342 insertions(+), 856 deletions(-)

This is a tough patch to do all at once, but nice job.

It's really hard to review what is going on here, but I'll have to trust
it and then I can do a better review of the interaction with the driver
model after the patch is applied.

One minor nit though, make the DEVICE_ATTR* all static please, and
possibly use ATTRIBUTE_GROUPS()?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux